Skip to content

Do auth while loading #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NunoDasNeves merged 3 commits into from
Feb 11, 2019
Merged

Do auth while loading #356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fa3a84
checkAuth uses startLoad and endLoad
NunoDasNeves Feb 11, 2019
28f072f
removed loading state commits from checkAuth
NunoDasNeves Feb 11, 2019
fe9cb6d
Merge remote-tracking branch 'origin' into do-auth-while-loading
NunoDasNeves Feb 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions frontend/src/store/auth/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// firebase authentication class
import auth from './config'
import CV from './CV'
import { startLoad, endLoad } from '../../utils/helpers'

import { createProfile, updateProfile, getSelf } from '@/utils/api/auth'

Expand Down Expand Up @@ -194,7 +195,9 @@ const actions = {
* If anything fails it clears everything
*/
async checkAuth({ commit, dispatch, state }) {
commit('SET_LOADING', true)
// app loading screen while checking auth
startLoad('Auth')

try {
// returns user object
const user = await new Promise((resolve, reject) => {
Expand Down Expand Up @@ -238,7 +241,8 @@ const actions = {
// Note we _need_ to do this before returning!
commit('SIGNAL_AUTH_CV')

commit('SET_LOADING', false)
// done auth check; show the app
endLoad('Auth')
},

/**
Expand Down