WWSTCERT-8756 Add support to frient air quality sensor #2439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 71 files 469 suites 0s ⏱️ Results for commit dc86e72. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against dc86e72 |
…ir-quality-sensor
…ir-quality-sensor
…thub.com/marcintyminski/SmartThingsEdgeDrivers into Add-support-to-frient-air-quality-sensor
greens
changed the title
pegor-karoglanian
approved these changes
Nov 6, 2025
wkhenon
approved these changes
Nov 7, 2025
greens
reviewed
Nov 11, 2025
| local function voc_measure_value_attr_handler(driver, device, attr_val, zb_rx) | ||
| local voc_value = attr_val.value | ||
| if (voc_value < 65535) then -- ignore it if it's outside the limits | ||
| log.trace("Received VOC MeasuredValue :"..util.stringify_table(voc_value)) |
Contributor
There was a problem hiding this comment.
if you're happy with the current state of the code, please remove logging statements.
greens
reviewed
Nov 11, 2025
|
|
||
| local function do_refresh(driver, device) | ||
| log.trace "Refreshing sensor attributes" | ||
| for _, fingerprint in ipairs(FRIENT_AIR_QUALITY_SENSOR_FINGERPRINTS) do |
Contributor
There was a problem hiding this comment.
are you expecting to add more models to this sub-driver?
Contributor
Author
There was a problem hiding this comment.
There is a possibility that we will need to add another model in the near future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests