Branching registryCredentialsId based off region and nodeLabel - #3148
Merged
Conversation
aleclorimer
requested review from
cjswedes,
ctowns,
hcarter-775,
varzac and
z-michel
July 27, 2026 16:45
aleclorimer
force-pushed
the
jenkins-docker-auth-fix
branch
from
July 27, 2026 16:46
345f4de to
ab31ed6
Compare
cjswedes
reviewed
Jul 27, 2026
| docker { | ||
| image 'python:3.10' | ||
| label "${params.NODE_LABEL ?: 'production'}" | ||
| registryUrl 'https://registry.artifactoryedge.streleng.cn' |
Contributor
There was a problem hiding this comment.
why the .cn registry URL?
Contributor
Author
There was a problem hiding this comment.
Whoops, this should probably be gated on CN and prod. Otherwise kept normal
hcarter-775
approved these changes
Jul 28, 2026
hcarter-775
left a comment
hcarter-775
left a comment
Contributor
There was a problem hiding this comment.
Since this is fairly specific code that doesn't really have codified reasons to exist, I would suggest adding some commentary in the file itself (tbh, effectively what's in the PR description). The table you have helps clarify what we're expecting here, so I just don't want us to forget, or need to dig up the PR
elbe0046
approved these changes
Jul 28, 2026
cjswedes
approved these changes
Jul 28, 2026
aleclorimer
force-pushed
the
jenkins-docker-auth-fix
branch
from
July 28, 2026 21:58
b3906e4 to
9bcb729
Compare
aleclorimer
force-pushed
the
jenkins-docker-auth-fix
branch
from
July 28, 2026 21:58
9bcb729 to
4026115
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change looks to solve a jenkins workflow error in which the CN prod runner fails due to a credential error. The targeted logic of 'artifactory-credentials' when on the CN prod jenkins runner have been tested to work in a test environment. This change should have the affect of changing
registryCredentialsIdonly and the registryURL for CN Prod.