fix: correct capability presentation examples - #846
Open
sungmpar wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 20ce290 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capabilities:presentationhelp examples that used thenon-existent
capabilities:presentationscommand@smartthings/cliRoot cause
The command is registered as
capabilities:presentation, but four independentlyhard-coded help examples used
capabilities:presentations. The existing buildertest only verified that the example builder was called once, so incorrect
example arguments were not detected.
Verification
npm run buildnpm run test -- --runTestsByPath src/__tests__/commands/capabilities/presentation.test.ts --no-watchmannpm run lintnpm run test -- --no-watchmangit diff --check upstream/main...HEADnode dist/src/run.js capabilities:presentation --helpThe built help output contains all four corrected singular examples and zero
capabilities:presentationsexamples. The README generator ran as part ofnpm run buildand produced no tracked README change.Fixes #842
Checklist
npm run lintproduces no warnings/errors)