Make the non-grav placeholder negligible and the discarded refinement visible - #540
Merged
Conversation
… visible Two small defects in the same path, both of which hide a failed non-grav fit. ASSIST skips the non-gravitational block entirely when A1=A2=A3=0, so a zero seed would leave the parameter's column zero. The fit substitutes a placeholder to avoid that, and the partial does not depend on its magnitude -- but the value chosen, 1e-15 au/day^2, is the order of a real Yarkovsky amplitude. On (6489) Golevka it is 6% of the true A2 and raises the starting chi-square from 12,888 to 138,416 before the first iteration, which is enough to trip the chi-square gate and discard the fit. Use 1e-20, which restores the gravity-only chi-square exactly. When the joint fit does return a non-zero flag the driver keeps the six-parameter solution and reports the non-grav parameters as NaN, which is right, but said so only at DEBUG. The caller sees flag 0, a chi-square belonging to the gravity fit, and NaN parameters, with nothing to explain them. Warn instead, and name the flag the joint fit returned: 6 is a weakly-constrained solution, not a failure to converge, and 2 is a fit rejected on chi-square. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #539.
Placeholder 1e-15 → 1e-20 au/day², and the discarded-refinement message moves from DEBUG to WARNING and now names the flag the joint fit actually returned — 6 is a weakly-constrained solution, not a failure to converge, and 2 is a fit rejected on chi-square.
🤖 Generated with Claude Code