Run the close-propagation test on Windows again - #3
Merged
Conversation
The race it kept losing is fixed, so the reason for holding it out is gone. This also puts the fix in front of the machine that was best at breaking it: the Windows job is where that test failed twice, and it is the one place the fix has not yet had to prove itself. The slow-reader test stays out. Its stall is a different thing that nobody has explained yet — 32KB short of 4MB, which is exactly the granularity of a window update — and the comment now says only that. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The race
TestForwardClosePropagateskept losing was fixed in #2, so the reasonfor holding it out of the Windows job is gone.
This is also the point: the Windows runner is where that test failed twice, and
it is the one machine the fix has not yet had to prove itself on. A green run
here is the verification, not a formality.
TestForwardEndToEndSlowReaderDoesNotResetTheStreamstays skipped. Its stall isa separate, unexplained thing — 32KB short of a 4MB stream, exactly the
granularity of a window update — and the comment now says that and only that,
rather than describing it as part of a race that has since been fixed.
🤖 Generated with Claude Code