Skip to content

Unify handling of partitioning with no edge features#334

Merged
mkolodner-sc merged 3 commits intomainfrom
mkolodner-sc/handle_partition_edge_none
Sep 22, 2025
Merged

Unify handling of partitioning with no edge features#334
mkolodner-sc merged 3 commits intomainfrom
mkolodner-sc/handle_partition_edge_none

Conversation

@mkolodner-sc
Copy link
Copy Markdown
Collaborator

@mkolodner-sc mkolodner-sc commented Sep 22, 2025 •
edited
Loading

Scope of work done

  • In the scenario where we don't have any partitioned edge features or edge partition books, we currently return an empty dictionary in the heterogeneous setting. To conform better to how we handle node features or node labels, where we return None rather than empty dictionaries, we should have this instead return None as well.
  • Additionally, there were uncaught typing issues where we may have forgotten to type these edge pb and features fields as Optional even when they could beNone in the returned output. We've updated this to now be correct.
  • Updates tests based on this new behavior

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@mkolodner-sc mkolodner-sc mentioned this pull request Sep 22, 2025
Merged
@mkolodner-sc
Copy link
Copy Markdown
Collaborator Author

mkolodner-sc commented Sep 22, 2025

/unit_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 22, 2025 •
edited
Loading

GiGL Automation

@ 19:15:11UTC : 🔄 Unit Test started.

@ 19:58:09UTC : ✅ Workflow completed successfully.

kmontemayor2-sc
kmontemayor2-sc approved these changes Sep 22, 2025
View reviewed changes
Comment thread python/gigl/distributed/dist_partitioner.py Outdated
Comment thread python/gigl/distributed/dist_partitioner.py
Comment thread python/tests/unit/distributed/distributed_partitioner_test.py Outdated
@mkolodner-sc
Copy link
Copy Markdown
Collaborator Author

mkolodner-sc commented Sep 22, 2025

/unit_test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 22, 2025 •
edited
Loading

GiGL Automation

@ 20:29:36UTC : 🔄 Unit Test started.

@ 21:09:11UTC : ✅ Workflow completed successfully.

@mkolodner-sc mkolodner-sc marked this pull request as ready for review September 22, 2025 20:46
@mkolodner-sc mkolodner-sc added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit 718ebe6 Sep 22, 2025
4 checks passed
@mkolodner-sc mkolodner-sc deleted the mkolodner-sc/handle_partition_edge_none branch September 22, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yliu2-sc yliu2-sc yliu2-sc approved these changes

@kmontemayor2-sc kmontemayor2-sc kmontemayor2-sc approved these changes

@svij-sc svij-sc Awaiting requested review from svij-sc svij-sc is a code owner

@nshah-sc nshah-sc Awaiting requested review from nshah-sc nshah-sc is a code owner

@xgao4-sc xgao4-sc Awaiting requested review from xgao4-sc xgao4-sc is a code owner

@zfan3-sc zfan3-sc Awaiting requested review from zfan3-sc zfan3-sc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkolodner-sc @yliu2-sc @kmontemayor2-sc