Add get_cluster_spec to get cluster spec on VAI#358
Merged
kmontemayor2-sc merged 9 commits intomainfrom Oct 8, 2025
Merged
Conversation
Collaborator
Author
|
/unit_test |
Collaborator
Author
|
/integration_test |
Contributor
GiGL Automation@ 15:41:11UTC : 🔄 |
Contributor
GiGL Automation@ 15:41:20UTC : 🔄 @ 16:44:04UTC : ✅ Workflow completed successfully. |
kmontemayor2-sc
commented
Oct 7, 2025
Collaborator
Author
|
/unit_test |
Contributor
GiGL Automation@ 16:58:29UTC : 🔄 |
svij-sc
reviewed
Oct 8, 2025
svij-sc
reviewed
Oct 8, 2025
svij-sc
approved these changes
Oct 8, 2025
Collaborator
svij-sc
left a comment
svij-sc
left a comment
There was a problem hiding this comment.
Couple suggestions to clean this up a bit.
kmontemayor2-sc
requested review from
mkolodner-sc,
nshah-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
mkolodner-sc
approved these changes
Oct 8, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Doing this per offline discussions to get server/client setup from env variables. I have #355 as a bigger change but we can break this out so I did :)
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: YES