-
Notifications
You must be signed in to change notification settings - Fork 14
Add get_cluster_spec to get cluster spec on VAI
#358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
74d8df1
Add utils to parse VAI CLUSTER_SPEC
kmonte de1de6a
comments
kmonte fc0dca4
rename
kmonte d3319d6
fixes
kmonte 0905664
fixes
kmonte 112d0ad
fix
kmonte f621bc7
address comments
kmonte fee17c1
Merge branch 'main' into kmonte/parse-cluster-spec
kmonte 9b99706
reword
kmonte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,6 @@ | ||
| from dataclasses import dataclass | ||
| from gigl.env.distributed import DistributedContext | ||
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class DistributedContext: | ||
| """ | ||
| GiGL Distributed Context | ||
| """ | ||
|
|
||
| # TODO (mkolodner-sc): Investigate adding local rank and local world size | ||
|
|
||
| # Main Worker's IP Address for RPC communication | ||
| main_worker_ip_address: str | ||
|
|
||
| # Rank of machine | ||
| global_rank: int | ||
|
|
||
| # Total number of machines | ||
| global_world_size: int | ||
| # TODO (mkolodner-sc): Deprecate this file. | ||
| __all__ = [ | ||
| "DistributedContext", | ||
| ] |
|
kmontemayor2-sc marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| """Information about distributed environments.""" | ||
|
|
||
| from dataclasses import dataclass | ||
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class DistributedContext: | ||
| """ | ||
| GiGL Distributed Context | ||
| """ | ||
|
|
||
| # TODO (mkolodner-sc): Investigate adding local rank and local world size | ||
|
|
||
| # Main Worker's IP Address for RPC communication | ||
| main_worker_ip_address: str | ||
|
|
||
| # Rank of machine | ||
| global_rank: int | ||
|
|
||
| # Total number of machines | ||
| global_world_size: int |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.