expose boot disk size for VAI configs#454
Merged
mkolodner-sc merged 1 commit intomainfrom Jan 22, 2026
Merged
Conversation
zfan3-sc
requested review from
kmontemayor2-sc,
mkolodner-sc,
nshah-sc,
svij-sc,
xgao4-sc and
yliu2-sc
as code owners
Co-authored-by: kmontemayor <kyle.e.montemayor@gmail.com>
zfan3-sc
force-pushed
the
zfan3/config
branch
from
ea16ba2 to
b2734df
Compare
Collaborator
|
nit. maybe a different PR title, I was very confused why you were sending some pr about the gs examples :P |
zfan3-sc
changed the title
mkolodner-sc
approved these changes
Jan 21, 2026
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thank Zihao! May want to update the PR name but otherwise LGTM
Collaborator
Author
|
Yep PR title updated |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Expose
boot_disk_size_gbfor VertexAI job configs.ran
make compile_protosWhere is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO