Skip to content

expose boot disk size for VAI configs #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkolodner-sc merged 1 commit into from
Jan 22, 2026
Merged

expose boot disk size for VAI configs #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions proto/snapchat/research/gbml/gigl_resource_config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ message VertexAiResourceConfig {
// The available options are in the GCP docs:
// https://docs.cloud.google.com/python/docs/reference/aiplatform/latest/google.cloud.aiplatform_v1.types.Scheduling.Strategy
string scheduling_strategy = 7;

// Boot disk size in GB for the job.
// If unset or zero, will use the default of 100 GB.
uint32 boot_disk_size_gb = 8;
}

// Configuration for KFP job resources
Expand Down
3 changes: 3 additions & 0 deletions python/gigl/src/common/vertex_ai_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,9 @@ def _build_job_config(
)
if vertex_ai_resource_config.scheduling_strategy
else None,
boot_disk_size_gb=vertex_ai_resource_config.boot_disk_size_gb
if vertex_ai_resource_config.boot_disk_size_gb
else 100, # Default to 100 GB for backward compatibility
)
return job_config

Expand Down
48 changes: 24 additions & 24 deletions python/snapchat/research/gbml/gigl_resource_config_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion python/snapchat/research/gbml/gigl_resource_config_pb2.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ class VertexAiResourceConfig(google.protobuf.message.Message):
TIMEOUT_FIELD_NUMBER: builtins.int
GCP_REGION_OVERRIDE_FIELD_NUMBER: builtins.int
SCHEDULING_STRATEGY_FIELD_NUMBER: builtins.int
BOOT_DISK_SIZE_GB_FIELD_NUMBER: builtins.int
machine_type: builtins.str
"""Machine type for job"""
gpu_type: builtins.str
Expand All @@ -244,6 +245,10 @@ class VertexAiResourceConfig(google.protobuf.message.Message):
The available options are in the GCP docs:
https://docs.cloud.google.com/python/docs/reference/aiplatform/latest/google.cloud.aiplatform_v1.types.Scheduling.Strategy
"""
boot_disk_size_gb: builtins.int
"""Boot disk size in GB for the job.
If unset or zero, will use the default of 100 GB.
"""
def __init__(
self,
*,
Expand All @@ -254,8 +259,9 @@ class VertexAiResourceConfig(google.protobuf.message.Message):
timeout: builtins.int = ...,
gcp_region_override: builtins.str = ...,
scheduling_strategy: builtins.str = ...,
boot_disk_size_gb: builtins.int = ...,
) -> None: ...
def ClearField(self, field_name: typing_extensions.Literal["gcp_region_override", b"gcp_region_override", "gpu_limit", b"gpu_limit", "gpu_type", b"gpu_type", "machine_type", b"machine_type", "num_replicas", b"num_replicas", "scheduling_strategy", b"scheduling_strategy", "timeout", b"timeout"]) -> None: ...
def ClearField(self, field_name: typing_extensions.Literal["boot_disk_size_gb", b"boot_disk_size_gb", "gcp_region_override", b"gcp_region_override", "gpu_limit", b"gpu_limit", "gpu_type", b"gpu_type", "machine_type", b"machine_type", "num_replicas", b"num_replicas", "scheduling_strategy", b"scheduling_strategy", "timeout", b"timeout"]) -> None: ...

global___VertexAiResourceConfig = VertexAiResourceConfig

Expand Down
Loading