Skip to content

Update RPM script for Rocky Linux 9 - #667

Merged
JohnSully merged 1 commit into
Snapchat:mainfrom
teemuke-kk:pkg-rpm-rocky9
Mar 8, 2024
Merged

Update RPM script for Rocky Linux 9#667
JohnSully merged 1 commit into
Snapchat:mainfrom
teemuke-kk:pkg-rpm-rocky9

Conversation

@teemuke-kk

Copy link
Copy Markdown
Contributor

KeyDB compiles on Rocky Linux 9 and 'make test' passes completely. However, the RPM package generation script was incompatible, as it relied on the version information of CentOS packages that were not available on Rocky Linux. This pull request uses the 'dist' RPM macro instead, which works on CentOS 7 and 8 as well.

This should work on CentOS Stream 9, RHEL 9, and variants like AlmaLinux 9 as well. Hopefully, there is going to be official RPM packages for these systems.

This uses the 'dist' RPM macro instead of relying on the version information of
CentOS packages.  This approach works on CentOS 7 and 8 as well.
@teemuke-kk

Copy link
Copy Markdown
Contributor Author

Additionally, a list of build requirements on Rocky Linux 9:

dnf install --assumeyes git make g++ rpmdevtools bzip2-devel curl-devel libatomic libuuid-devel libzstd-devel lz4-devel numactl-devel openssl-devel scl-utils systemd-devel tcl-devel

dnf install --assumeyes epel-release
dnf install --assumeyes jemalloc-devel tcltls

dnf config-manager --assumeyes --set-enabled crb
dnf install --assumeyes snappy-devel

This might not be an exhaustive list. I used the build instructions for CentOS 8 as a reference but I tried to avoid installing the whole "Development tools" group.

@jogoossens

Copy link
Copy Markdown

Please provide also office RedHat 9 packages (as in compatible with Alma and Rocky 9) :)

@matejzero

Copy link
Copy Markdown

We would also be really happy if AL9 pkgs would be released as we are upgrading out fleet from C7 to AL9. Any way to push this forward?

@matejzero

Copy link
Copy Markdown

Looking at spec file, initscripts and chkconfig requirements can also be removed as they are not needed on systemd system.

@JohnSully
JohnSully merged commit 2cb5d71 into Snapchat:main Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants