fix: timelapse download robustness + device-switch + open-folder - #656
Merged
SukiSunYuhang merged 1 commit intoAug 3, 2026
Conversation
- Invalid download path (e.g. USB removed): bail out before downloading instead of crashing on file write - Cancel still completes: WAN cancel now erases g_wan_pending and the deferred sw_NotifyUploadTimelaspe kickoff checks skipped_indices, so a cancelled file can't be restarted; cancel callback runs cancel_download immediately (no CallAfter window) - Delete a downloading file: sw_DeleteCameraTimelapse aborts the matching PC download by date_index - Progress regression on weak network: on_progress percent is monotonic (no backward jump from dlnow fluctuation) - Device switch (sw_mqtt_set_engine): cancel_all_active_timelapse stops every in-flight download and marks each unfinished file as "Download Failed"; on_error skipped branch skips mark when ctx->cancelled so the failed state isn't overridden by "cancelled" - New sw_OpenTimelapseFolder interface + desktop_open_folder helper: open the containing folder even when the file was deleted externally (sw_FileView kept unchanged for other callers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: