fix(gui): dark-mode icons, layout shift and DPI rescale in mixed-filament batch dialog - #726
Merged
Kenshin627 merged 2 commits intoAug 18, 2026
Conversation
- Center the preview placeholder by logical size (GetScaledSize) so the Retina-rasterized bitmap is no longer shifted toward the top-left on macOS - Add _light icon variants for the add/remove and tray nav buttons, and set explicit disabled-state bitmaps (muted opposite-palette asset) so the four states are distinguishable in both themes - Pin title rows to 20 DIP and manual-card rows to 30 DIP (matching the recommended card), and pin add/remove buttons to 16x16 DIP, so cards no longer shift when switching between recommended and manual modes - Refine zh_CN translation of the mix-ratio range warning
Button::Rescale() refreshes icons, re-measures the cached text extent (messureSize) and re-applies the style. It was missing for m_btn_batch_match in Sidebar::msw_rescale() and sys_color_changed(), so the label drifted/clipped after a DPI or theme change while the sibling flushing-volume button stayed correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up UI fixes for the mixed-filament batch color-match dialog introduced in #702, plus the related sidebar button:
_lightvariants for the add/remove and tray-nav buttons and set explicitdisabled-state bitmaps (muted opposite-palette asset), so enabled/disabled states are distinguishable
in both light and dark themes.
GetScaledSize) soRetina-rasterized bitmaps are no longer shifted toward the top-left; identity for scale-1.0 bitmaps,
so Windows/Linux rendering is unchanged.
card), and add/remove buttons to 16x16 DIP, so cards no longer shift when switching between
recommended and manual modes.
Rescale()inmsw_rescale()andsys_color_changed(). Its cached text extent (messureSize) otherwise goes stale after a per-monitorDPI change or theme switch, making the label drift or clip.
No breaking changes, no new dependencies.
Tests
Manual verification (Windows 11):