Tests for ShoppingCart service and controller.#18
Merged
Conversation
liliia-ponomarenko
approved these changes
Jun 16, 2025
liliia-ponomarenko
left a comment
liliia-ponomarenko
left a comment
Contributor
There was a problem hiding this comment.
Good job! A few recommendation ;)
| import org.mockito.junit.jupiter.MockitoExtension; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| class ShoppingCartServiceTest { |
Contributor
There was a problem hiding this comment.
Better use Given-When-Then construction and improve readability
Comment on lines
+66
to
+76
| void setUp() { | ||
| user = new User(); | ||
| user.setId(USER_ID); | ||
| book = new Book(); | ||
| book.setId(BOOK_ID); | ||
| book.setTitle("Test Book"); | ||
| book.setAuthor("Test Author"); | ||
| book.setIsbn("978-3-16-148410-0"); | ||
| book.setPrice(new BigDecimal("29.99")); | ||
| cartItem = new CartItem(); | ||
| cartItem.setId(CART_ITEM_ID); |
Contributor
There was a problem hiding this comment.
better move test data to the util class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.