Skip to content

Remove defunct FDB emergency movement commands#560

Merged
sfc-gh-abeamon merged 4 commits into
mainfrom
abeamon/fdbcore-21325-remove-emove
Jun 3, 2025
Merged

Remove defunct FDB emergency movement commands#560
sfc-gh-abeamon merged 4 commits into
mainfrom
abeamon/fdbcore-21325-remove-emove

Conversation

@sfc-gh-abeamon

Copy link
Copy Markdown
Collaborator

This removes the already unusable FDB emergency movement commands from sansshell

@sfc-gh-abeamon

Copy link
Copy Markdown
Collaborator Author

From the incompatible protoc changes lint:

Error: Previously present message "FDBCLITenantEmergencyMove" was deleted from file.
Error: Previously present message "FDBCLITenantEmergencyMoveAbort" was deleted from file.
Error: Previously present message "FDBCLITenantEmergencyMoveFinish" was deleted from file.
Error: Previously present message "FDBCLITenantEmergencyMoveStart" was deleted from file.
Error: Previously present message "FDBCLITenantEmergencyMoveStatus" was deleted from file.
Error: Previously present message "FDBCLITenantEmergencyMoveSwitch" was deleted from file.
Error: Previously present message "FDBMoveDataCopyRequest" was deleted from file.
Error: Previously present message "FDBMoveDataCopyResponse" was deleted from file.
Error: Previously present message "FDBMoveDataWaitRequest" was deleted from file.
Error: Previously present message "FDBMoveDataWaitResponse" was deleted from file.
Error: Previously present service "FDBMove" was deleted from file.
Error: Previously present field "49" with name "tenant_emergency_move" on message "FDBCLICommand" was deleted.

Per recommendation elsewhere, I removed these without deprecation due to the fact that they are currently unusable anyway. If there are alternate suggestions to bypass the check or make a different change, I can do so.

Comment thread services/fdb/fdb.pb.go Outdated
@sfc-gh-abeamon sfc-gh-abeamon marked this pull request as ready for review April 30, 2025 16:52
Comment thread services/fdb/fdb.proto
Comment thread services/fdb/fdb.pb.go Outdated
@sfc-gh-abeamon sfc-gh-abeamon force-pushed the abeamon/fdbcore-21325-remove-emove branch from 6d55e70 to 45ca04f Compare May 23, 2025 22:46
@sfc-gh-abeamon sfc-gh-abeamon merged commit 96bda6b into main Jun 3, 2025
7 checks passed
@sfc-gh-abeamon sfc-gh-abeamon deleted the abeamon/fdbcore-21325-remove-emove branch June 3, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants