fix(ci): build the Maven extension jar outside the Socket Firewall shims#1390
Merged
Jeppe Fredsgaard Blaabjerg (jfblaa) merged 3 commits intoJul 1, 2026
Merged
Conversation
The release build failed because `pnpm run build:maven-extension` runs the whole build subtree (pnpm -> bash -> mvnw -> wget) under Socket Firewall, which shims the package managers it wraps. sfw then intercepts the Maven wrapper's download of Maven from Maven Central and fails on that non-package fetch. Invoke build-jar.sh directly instead. bash/mvnw/wget aren't shimmed, so the Maven download runs outside the sfw-wrapped process tree and succeeds.
The standalone PR-time jar-build workflow doesn't run behind Socket Firewall, so it never exercised the environment the release actually uses (and gave false confidence). The jar is built in the release workflow and the version-compat matrix runs locally via run-compat.sh, so drop it.
Oskar Haarklou Veileborg (BarrensZeppelin)
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release build failed at the Maven-extension jar step. Root cause:
pnpm run build:maven-extensionruns the whole build subtree (pnpm → bash → mvnw → wget) under Socket Firewall, which intercepts by shimming the package managers it wraps (npm/yarn/pnpm/pip/uv/cargo). sfw then proxies the Maven wrapper's download of Maven from Maven Central and fails on that non-package fetch.The fix is a one-line change: invoke
build-jar.shdirectly rather than throughpnpm run.bash/mvnw/wgetaren't shimmed, so the Maven download runs outside the sfw-wrapped process tree and succeeds. The jar stays uncommitted and is still bundled intodist/manifest-scriptsat build time.Relationship to #1387
This is the lighter-touch alternative to #1387 (which commits the prebuilt jar). Preference is to land this if it builds green in the release, and keep #1387 as the fallback if the direct invocation still trips the firewall.
Note
Low Risk
Single workflow-step change with no runtime or auth impact; only affects how the release job builds an uncommitted jar.
Overview
Fixes release CI failures when building the Maven manifest extension jar by invoking
build-jar.shwithbashinstead ofpnpm run build:maven-extension.In the publish workflow, Socket Firewall shims
pnpm, so the previous path nestedmvnw/Maven Central downloads under sfw and broke on non-package fetches. Directbashkeeps that download outside the shimmed package-manager tree; JDK selection viaJAVA_HOME_17_X64is unchanged, and the jar still bundles intodist/manifest-scriptsfor publish.Reviewed by Cursor Bugbot for commit 59f7e2a. Configure here.