Clear node_modules just in case for pnpm local runs of fix#618
Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom May 29, 2025
Merged
Clear node_modules just in case for pnpm local runs of fix#618John-David Dalton (jdalton) merged 1 commit intomainfrom
John-David Dalton (jdalton) merged 1 commit intomainfrom
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| if (!actualTree) { | ||
| if (!isCi) { | ||
| // eslint-disable-next-line no-await-in-loop | ||
| await removeNodeModules(cwd) |
Contributor
There was a problem hiding this comment.
This comment appears to be unnecessary. The codebase is using a consistent style without semicolons at the end of statements, as seen in the surrounding code. The JavaScript language has automatic semicolon insertion (ASI), and many modern codebases intentionally omit semicolons as a style choice. Unless there's a specific linting rule or team convention requiring explicit semicolons, this change isn't needed.
Spotted by Diamond (based on custom rules)
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.