Skip to content

Clear node_modules just in case for pnpm local runs of fix #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
John-David Dalton (jdalton) merged 1 commit into from
May 29, 2025
Merged

Clear node_modules just in case for pnpm local runs of fix #618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/commands/fix/pnpm-fix.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,10 @@ export async function pnpmFix(

// actualTree may not be defined on the first iteration of pkgJsonPathsLoop.
if (!actualTree) {
if (!isCi) {
// eslint-disable-next-line no-await-in-loop
await removeNodeModules(cwd)
Copy link
Copy Markdown
Contributor

@graphite-app graphite-app bot May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment appears to be unnecessary. The codebase is using a consistent style without semicolons at the end of statements, as seen in the surrounding code. The JavaScript language has automatic semicolon insertion (ASI), and many modern codebases intentionally omit semicolons as a style choice. Unless there's a specific linting rule or team convention requiring explicit semicolons, this change isn't needed.

Spotted by Diamond (based on custom rules)

Is this helpful? React 👍 or 👎 to let us know.

}
const maybeActualTree =
isCi && existsSync(path.join(rootPath, 'node_modules'))
? // eslint-disable-next-line no-await-in-loop
Expand Down