Apply ruff autofixes and add a ruff CI job - #342
Merged
Conversation
Result of `uv run ruff check --fix --unsafe-fixes`: sort and regroup imports (isort), drop unused imports, remove f-string prefixes from strings with no placeholders, drop unused bindings, and simplify `== True`/`== False` assertions to truthiness checks.
Mirrors the checkout and python setup from python-tests. Installs the dev extra rather than test, since that is where the ruff pin lives.
|
❌ Version Check Failed Please increment... |
Oskar Haarklou Veileborg (BarrensZeppelin)
requested review from
lelia and
Martin Torp (mtorp)
September 4, 2026 08:28
Oskar Haarklou Veileborg (BarrensZeppelin)
marked this pull request as ready for review
September 4, 2026 08:28
Oskar Haarklou Veileborg (BarrensZeppelin)
requested a review
from a team
as a code owner
September 4, 2026 08:28
Martin Torp (mtorp)
approved these changes
Sep 4, 2026
Oskar Haarklou Veileborg (BarrensZeppelin)
merged commit Sep 4, 2026
eb3e46a
into
main
41 of 43 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs
uv run ruff check --fix --unsafe-fixesover the tree and wires ruff into CI so it stays clean.Changes
fprefixes on strings with no placeholders, dropped unused bindings, and== True/== Falseassertions simplified to truthiness checks.ruffjob in.github/workflows/python-tests.yml, mirroring the checkout and Python setup frompython-tests. It installs thedevextra rather thantest, since that is where the ruff pin lives.Notes for review
The
ruffjob isn't required to pass, so it only buys visibility for now.Verification
uv run ruff checkpasses and the suite is green — 423 passed, 2 skipped.Note
Low Risk
Style and import-only edits plus a non-blocking CI lint job; no changes to auth, API contracts, or core scan logic.
Overview
Adds a dedicated
ruffGitHub Actions job that checks out the repo, installs deps withuv sync --extra dev, and runsuv run ruff checkso lint stays enforced in CI (alongside existing unit tests and pip-audit).The rest of the PR is mechanical ruff cleanup across the library and tests: isort-style import ordering, removal of unused imports (e.g. in
lazy_file_loader,resource_utils, several test modules), dropping pointless f-strings in log messages, tightening bareexcepthandlers, and small test tweaks (truthiness assertions, dropping unusedresultbindings). No intentional behavior changes beyond what those lint rules require.Reviewed by Cursor Bugbot for commit 0d25ca1. Configure here.