Fix export mapping pointing to invalid src folder#181
Conversation
Release 3.0.1 and correct the root `exports` entry to point at `./bin/index.js` instead of the invalid `./bin/src/index.js`, so package consumers resolve the main import correctly.
There was a problem hiding this comment.
Pull request overview
This PR updates the package’s root export map so consumers can import from the package root (via the compiled bin/index.js) instead of an invalid bin/src/index.js path.
Changes:
- Fix the root
exports["."].importentry to point to./bin/index.js. - Bump package version from
3.0.0to3.0.1(and sync the lockfile).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Fixes the root export mapping and bumps the package version. |
| package-lock.json | Updates the lockfile version fields to match the package version bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "exports": { | ||
| ".": { | ||
| "import": "./bin/src/index.js" | ||
| "import": "./bin/index.js" | ||
| }, |
There was a problem hiding this comment.
Deleted bin and re-ran build:Prod which produces bin/index.js - AI comment is invalid unless I'm missing something
There was a problem hiding this comment.
AI is false positive because it's not accounting for this script:
"prebuild:Prod": "tsc -p prod.tsconfig.json --emitDeclarationOnly false",
Elliot Huffman (elliot-huffman)
left a comment
Elliot Huffman (elliot-huffman)
left a comment
There was a problem hiding this comment.
Looks good to me!
Correct the root
exportsentry to point at./bin/index.jsinstead of the invalid./bin/src/index.js, so package consumers resolve the main import correctly.Before change, imports must be:
import { eslintConfig } from '@shi-corp/development-utilities/optimized/lint/base.js'after change:
import { baseLintConfig } from '@software-hardware-integration-lab/development-utilities'Change is backwards compatible so won't break consumers that auto upgrade to 3.0.1 but keep previous import syntax