LAB-611 Cloud Matrix Endpoint Specifications#126
Conversation
- Introduces the CloudMatrix schema to the API specification, representing cloud matrix assessment records. - Adds the /Api/CloudMatrix/Dashboard GET endpoint for retrieving cloud matrix records with optional date filters. - Adds the 'Cloud Matrix Assessment' tag for API documentation.
…/LAB-1051_Create-OpenAPI-Spec-For-CMA-Dashboard-Data LAB-1051
…elation Updated schema references, endpoint descriptions, tags, and summaries to use 'CloudMatrix.Correlation' instead of 'CloudMatrixAssessment.Correlation' for consistency and clarity in the API specification.
Updated schema references and descriptions from 'CloudMatrix.Correlation' to 'CloudMatrixCorrelationRecord' for clarity and consistency. Also updated related descriptions and titles to reflect the new naming, and adjusted the operation name and description for the cloud matrix feature.
Renamed the tag from 'Cloud Matrix Correlation' to 'Cloud Matrix' and revised the description for clarity in the Data-Gateway.json specification.
Revised descriptions for CloudMatrixCorrelationRecord and Cloud Matrix to improve clarity and consistency in terminology within the Data-Gateway.json specification.
…/LAB-1198_Update_OpenAPI_Description_For_CM_Updated_Table Feature/lab 1198 update open api description for cm updated table
…-create-open-api-spec
…create-open-api-spec LAB-1054 Create OpenAPI Spec for GET /Api/CloudMatrix/Assessment endpoint
…-open-api-update-get-dashboard-spec-to-use-template LAB-1367 Rename publisher to template for Cloud Matrix Correlation Record.
Fix the example values of the get Dashboard endpoint to values to align with the current database schema.
Initial Check in
- Normalize and enrich the MyData-Gateway OpenAPI schema: correct OpenAPI version. - Introduce a reusable Uuid schema, and reorganize many component schemas under a CloudMatrix namespace. - Update numerous $ref targets to the new paths. - Replace single `example` fields with `examples` arrays, and add descriptive `description` and `examples` metadata across schemas. - Expand and restructure example payloads (assessment, displacements, features, costs) and adjust a few content values. - These changes improve schema clarity, reuse, and sample coverage for validation and documentation.
- Refactor and expand the CloudMatrix definition in specs/Data-Gateway.json. - Tighten validation (additionalProperties=false, required lists), reorder properties - Add detailed nested component schemas (ValueAssessment, ActionPlan, UserProfile, AssessmentElement, AssessmentMetadata, YearConfig, Feature/Product/Subscription entries, Displacement/Provider/Cost types, Breakout and BreakoutFeature) - Update examples and sample IDs/values, and fix $ref targets.
Do not need the required property as it exists on the underlying accountId object
…port/Correlation/{correlationId}/Tenant/{tenantId}/Data endpoint parameters
…nt/{accountId}/Correlation/{correlationId}/Data endpoint parameters
…nt/{accountId}/Correlation/{correlationId} and /Api/CloudMatrix/Correlation/{correlationId}/Data endpoint parameters
…-implement-internal-external-user-branching-logic Lab 1735 implement internal external user branching logic
…llable-primitive-types LAB-1874 - Fix OpenAPI spec for Kiota limitation.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- src/dataGateway/TypeScript/package-lock.json: Language not supported
Comments suppressed due to low confidence (8)
src/dataGateway/TypeScript/package-lock.json:1413
libcconstraints were removed from the@unrs/resolver-bindinglinux-* entries. Withoutlibc, npm may treat both the *-gnu and *-musl bindings as installable on the same Linux+CPU combination, which can cause extra/incorrect native binding installs (notably on Alpine/musl). Regenerate the lockfile in a way that preserveslibcfiltering (compare to src/urlShortener/TypeScript/package-lock.json where these entries includelibc).
src/dataGateway/TypeScript/package-lock.json:1427libcconstraints were removed from the@unrs/resolver-bindinglinux-* entries. Withoutlibc, npm may treat both the *-gnu and *-musl bindings as installable on the same Linux+CPU combination, which can cause extra/incorrect native binding installs (notably on Alpine/musl). Regenerate the lockfile in a way that preserveslibcfiltering (compare to src/urlShortener/TypeScript/package-lock.json where these entries includelibc).
src/dataGateway/TypeScript/package-lock.json:1469libcconstraints were removed from the@unrs/resolver-bindinglinux-* entries. Withoutlibc, npm may treat both the *-gnu and *-musl bindings as installable on the same Linux+CPU combination, which can cause extra/incorrect native binding installs (notably on Alpine/musl). Regenerate the lockfile in a way that preserveslibcfiltering (compare to src/urlShortener/TypeScript/package-lock.json where these entries includelibc).
src/dataGateway/TypeScript/package-lock.json:1441libcconstraints were removed from the@unrs/resolver-bindinglinux-* entries. Withoutlibc, npm may treat both the *-gnu and *-musl bindings as installable on the same Linux+CPU combination, which can cause extra/incorrect native binding installs (notably on Alpine/musl). Regenerate the lockfile in a way that preserveslibcfiltering (compare to src/urlShortener/TypeScript/package-lock.json where these entries includelibc).
src/dataGateway/TypeScript/package-lock.json:1455libcconstraints were removed from the@unrs/resolver-bindinglinux-* entries. Withoutlibc, npm may treat both the *-gnu and *-musl bindings as installable on the same Linux+CPU combination, which can cause extra/incorrect native binding installs (notably on Alpine/musl). Regenerate the lockfile in a way that preserveslibcfiltering (compare to src/urlShortener/TypeScript/package-lock.json where these entries includelibc).
src/dataGateway/TypeScript/package-lock.json:1483libcconstraints were removed from the@unrs/resolver-bindinglinux-* entries. Withoutlibc, npm may treat both the *-gnu and *-musl bindings as installable on the same Linux+CPU combination, which can cause extra/incorrect native binding installs (notably on Alpine/musl). Regenerate the lockfile in a way that preserveslibcfiltering (compare to src/urlShortener/TypeScript/package-lock.json where these entries includelibc).
src/dataGateway/TypeScript/package-lock.json:1497libcconstraints were removed from the@unrs/resolver-bindinglinux-* entries. Withoutlibc, npm may treat both the *-gnu and *-musl bindings as installable on the same Linux+CPU combination, which can cause extra/incorrect native binding installs (notably on Alpine/musl). Regenerate the lockfile in a way that preserveslibcfiltering (compare to src/urlShortener/TypeScript/package-lock.json where these entries includelibc).
src/dataGateway/TypeScript/package-lock.json:1399libcconstraints were removed from the@unrs/resolver-bindinglinux-* entries. Withoutlibc, npm may treat both the *-gnu and *-musl bindings as installable on the same Linux+CPU combination, which can cause extra/incorrect native binding installs (notably on Alpine/musl). Regenerate the lockfile in a way that preserveslibcfiltering (compare to src/urlShortener/TypeScript/package-lock.json where these entries includelibc).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update specs/Data-Gateway.json by replacing occurrences of the tenant property "displayName" with "tenantDisplayName" for tenant entries to align with the API model and ensure consistent property naming. Also add a missing newline at end of file to fix formatting.
pasha-zayko
left a comment
There was a problem hiding this comment.
Overall changes are accurate.
There is a swap in the description of 2 paths where tenant restriction applies or does not apply.
However, there is general missing information - all paths for CloudMatrix should have descriptions updated to list all permissions (especially including all .Del permissions that were newly introduced), as code outlines, that would allow access.
…-implement-internal-external-user-branching-logic LAB-1735:- Rename displayName to tenantDisplayName in spec
…trix/Account/{accountId}/Correlation/{correlationId}/Data and /Api/CloudMatrix/Correlation/{correlationId}/Data
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- src/dataGateway/TypeScript/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
src/dataGateway/TypeScript/package-lock.json:1401
- This lockfile drops the
libcconstraints for the platform-specific@unrs/resolver-binding-*-gnu/*-muslpackages (they now only haveos/cpu). In other SDK lockfiles these entries still includelibc, and removing it can cause npm to attempt installing both gnu and musl variants on the same Linux platform (larger installs and potential native install noise). Regenerate the lockfile with the repo-standard npm version/config so these constraints are preserved (or make lockfile generation consistent across SDK packages).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 3 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- src/dataGateway/TypeScript/package-lock.json: Language not supported
Comments suppressed due to low confidence (8)
src/dataGateway/TypeScript/package-lock.json:1399
package-lock.jsonremoves thelibcconstraint from the@unrs/resolver-binding-linux-*-gnuoptional binary entry. These gnu vs musl variants typically rely on thelibcfield to prevent installing the wrong binary on Alpine/musl vs glibc systems; removing it can break installs at runtime. This repository’s other TypeScript lockfile still includes theselibcfields (e.g.,src/urlShortener/TypeScript/package-lock.json), so this looks accidental—please regenerate the lockfile with the pinned npm version and keep thelibcconstraints (or explain why they’re safe to remove).
src/dataGateway/TypeScript/package-lock.json:1427package-lock.jsondrops thelibcfield from another@unrs/resolver-bindingLinux binary (ppc64 gnu). This makes the lockfile inconsistent with the urlShortener TypeScript lockfile and can lead to incorrect binary selection on different Linux libc environments. Please regenerate/restored thelibcconstraints across all@unrs/resolver-binding-linux-*entries.
src/dataGateway/TypeScript/package-lock.json:1497package-lock.jsonremoves thelibcselector from the@unrs/resolver-binding-linux-x64-muslentry. This may allow the musl binary to be installed on glibc systems (and vice versa), which can break runtime resolution of native bindings. Please restore thelibcconstraints by regenerating the lockfile with the pinned npm version.
src/dataGateway/TypeScript/package-lock.json:1413package-lock.jsonremoves thelibcconstraint from the@unrs/resolver-binding-linux-*-musloptional binary entry. Withoutlibc: ["musl"], npm can treat the musl variant as eligible on glibc Linux (and vice versa), which can cause incorrect native bindings to be installed. Please restore by regenerating the lockfile (and keep it consistent withsrc/urlShortener/TypeScript/package-lock.json, which still has these constraints).
src/dataGateway/TypeScript/package-lock.json:1441package-lock.jsonremoves thelibcselector from the@unrs/resolver-binding-linux-riscv64-gnuentry. Since there is also a-muslvariant for the same OS/CPU, omittinglibccan cause wrong native binding installs depending on the target distro. Please restorelibcby regenerating the lockfile.
src/dataGateway/TypeScript/package-lock.json:1455package-lock.jsonremoves thelibcselector from the@unrs/resolver-binding-linux-riscv64-muslentry. With onlyos/cpuconstraints, npm can no longer reliably filter between the-gnuand-muslpackages. Please restore thelibcconstraints by regenerating the lockfile with the repo’s pinned npm version.
src/dataGateway/TypeScript/package-lock.json:1469package-lock.jsonremoves thelibcselector from the@unrs/resolver-binding-linux-s390x-gnuentry. This changes platform filtering semantics for optional native packages and can cause installs to break on musl-based distros. Please restore thelibcconstraints (preferably vianpm installusing the pinned npm version) so the lockfile stays consistent across packages.
src/dataGateway/TypeScript/package-lock.json:1483package-lock.jsonremoves thelibcselector from the@unrs/resolver-binding-linux-x64-gnuentry. Given the presence of a corresponding-muslvariant, droppinglibccan lead to incorrect binary selection on Alpine vs non-Alpine Linux. Please restore by regenerating the lockfile, keepinglibcconstraints intact (as insrc/urlShortener/TypeScript/package-lock.json).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request introduces configuration changes to the workspace settings and updates to the TypeScript SDK exports. The main changes involve disabling GitHub Copilot features in the workspace and ensuring all necessary types are exported from the SDK for better TypeScript support.
EDIT:
This pull request updates the Data Gateway TypeScript SDK to version 3.2.0 and improves type exports for easier usage. The most significant changes include updating the package version and enhancing type exports for better TypeScript support.
Version Update:
3.1.0to3.2.0in bothpackage.jsonandpackage-lock.jsonto reflect new changes and ensure correct versioning. [1] [2]TypeScript Type Improvements:
DataGatewayClienttype fromdataGatewayClient.jsinindex.tsto make it directly accessible to SDK consumers.Dependency and Build Metadata:
libcfield from several platform-specific dependency entries inpackage-lock.json, simplifying the lockfile and potentially improving cross-platform compatibility. [1] [2] [3] [4] [5] [6] [7] [8]