Lab 2063 CM displacement expirationDate

[Craig Whittington (CraigFW)]

Added expirationDate for a singular source of truth, expiryDate and replacementDate will become deprecated

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

• src/dataGateway/TypeScript/package-lock.json: Language not supported

[Copilot]

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

• src/dataGateway/TypeScript/package-lock.json: Language not supported

Comments suppressed due to low confidence (2)

specs/Data-Gateway.json:3226

• replacementDate is marked deprecated, but it remains in the schema’s required list while the new expirationDate is optional. This makes it impossible for clients (especially for request schemas) to avoid the deprecated field. If expirationDate is intended to be the new source of truth, the required list should be updated accordingly.

                        "required": [
                            "costs",
                            "replacementDate"
                        ]

specs/Data-Gateway.json:3144

• The PR description says expiryDate was removed for a single source of truth, but the schema still defines expiryDate and keeps it required (and examples still use it). Either the PR description should be updated to reflect a deprecation-only change, or the schema should be updated to actually remove/replace expiryDate (which would be a breaking change).

                    "expiryDate": {
                        "$ref": "#/components/schemas/NullableDateTimeStringType",
                        "description": "DEPRECATED: Contract expiry date as an ISO 8601 date-time string, or null."
                    }
                },
                "required": [
                    "name",
                    "terms",
                    "contractNumber",
                    "expiryDate"
                ],