fix: onChange can also update other fields#564
Merged
wojtek-krysiak merged 1 commit intobetafrom Aug 27, 2020
Merged
Conversation
wojtek-krysiak
commented
Aug 27, 2020
| const propValue = record.params?.[property.name] ?? '' | ||
| const [value, setValue] = useState(propValue) | ||
|
|
||
| const previous = usePrevious(propValue) |
Contributor
Author
There was a problem hiding this comment.
removed usePrevious because the previous state is in value
| setValue(propValue) | ||
| } | ||
| }, []) | ||
| }, [propValue]) |
Contributor
Author
There was a problem hiding this comment.
added that which invalidates when external param was updated
|
🎉 This PR is included in version 3.1.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Co0sh there was an error where users couldn't update properties with onChange.
Baicaly this component didn't work:
Name property is a string and inside there is an inner state which was only updated from the external
paramson component mount.I've fixed that and will merge it, but please verify if this is ok.