Fix clippy errors (sans missing docs and one unused field)#107
Merged
SolarLiner merged 3 commits intoSolarLiner:mainfrom Nov 1, 2025
Merged
Fix clippy errors (sans missing docs and one unused field)#107SolarLiner merged 3 commits intoSolarLiner:mainfrom
SolarLiner merged 3 commits intoSolarLiner:mainfrom
Conversation
They are inevitable given the way this module is used.
SolarLiner
approved these changes
Oct 29, 2025
Owner
SolarLiner
left a comment
SolarLiner
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing the chores ! 😆
7 tasks
SolarLiner
added a commit
that referenced
this pull request
Nov 12, 2025
…114) ## Description A kind of follow-up to #107. This fixes all but but one clippy lints (at least for me on Linux with `--all-features`), most of the work was adding basic docs to the pipewire backend The last remaining lint is of unused field in DuplexCallback::resample_config. I assume this is somewhat WIP, also per #29 (same as in #107). ## Type of Change - [x] Documentation update - [x] Code cleanup or refactor ## How Has This Been Tested? Compiles. :) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - ~Wherever possible, I have added tests that prove my fix is effective or that my feature works.~ - [x] New and existing unit tests pass locally with my changes - [x] I have checked my code and corrected any misspellings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes most but not all clippy lints. The remaining firing lints are:
missing_docslints (we explicitly make this a warning). More work to resolve.DuplexCallback::resample_config. I assume this is somewhat WIP, also per API additions for duplex devices #29Type of Change
How Has This Been Tested?
Still compiles, gives less warnings.
Checklist:
I have made corresponding changes to the documentationWherever possible, I have added tests that prove my fix is effective or that my feature works.