Fix all but the last lint (mostly adds PipeWire backend docstrings)#114
Merged
SolarLiner merged 3 commits intoSolarLiner:mainfrom Nov 12, 2025
Merged
Fix all but the last lint (mostly adds PipeWire backend docstrings)#114SolarLiner merged 3 commits intoSolarLiner:mainfrom
SolarLiner merged 3 commits intoSolarLiner:mainfrom
Conversation
Tweaked copy&paste from their interleaved counterparts
strohel
changed the title
SolarLiner
approved these changes
Nov 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A kind of follow-up to #107.
This fixes all but but one clippy lints (at least for me on Linux with
--all-features), most of the work was adding basic docs to the pipewire backendThe last remaining lint is of unused field in DuplexCallback::resample_config. I assume this is somewhat WIP, also per #29 (same as in #107).
Type of Change
How Has This Been Tested?
Compiles. :)
Checklist:
Wherever possible, I have added tests that prove my fix is effective or that my feature works.