Add external wallet deposit option to card funding - #1970
Merged
Conversation
Adds "External Wallet" as a fourth option in the card deposit dropdown (after Borrow against Savings, Savings, and Wallet). When selected, the card funding address is rendered via the reusable DepositPublicAddress screen from the Add funds modal with a Base chain USDC description that links to the token contract on Basescan. - Extend DepositPublicAddress with optional `address` and `description` props so the "Your Solid address" screen can be reused for arbitrary deposit addresses. - Render the address screen inline in CardDepositInternalForm when the EXTERNAL source is chosen, hiding amount input, destination, error and submit UI for that mode.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for depositing USDC from external wallets to fund cards. Users can now select "External Wallet" as a deposit source and transfer USDC on the Base chain directly to their card's funding address.
Key Changes
CardDepositSource.EXTERNALoption to the source selector in both native and web implementationsaddressanddescriptionprops, allowing it to be reused for external wallet deposits with custom messagingImplementation Details
getCardFundingAddressutilityDepositPublicAddresscomponent now accepts optional overrides for address and description, making it reusable for different deposit scenariosBASE_USDC_TOKEN_URLconstant pointing to the USDC token on BaseScan for user referencehttps://claude.ai/code/session_016b47CP58T3FaoHqVJtyQPW