Skip to content

Wrap modal content with KeyboardAvoidingView for better keyboard handling #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MusabShakeel576 merged 1 commit into from
Apr 22, 2026
Merged

Wrap modal content with KeyboardAvoidingView for better keyboard handling #1978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 39 additions & 33 deletions components/ResponsiveModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { ReactNode, useCallback } from 'react';
import { Platform, ScrollView, View } from 'react-native';
import { KeyboardAvoidingView, Platform, ScrollView, View } from 'react-native';
import Animated, {
Easing,
FadeInLeft,
Expand Down Expand Up @@ -215,40 +215,46 @@ const ResponsiveModal = ({
className="relative"
style={useNativeFlexLayout ? { flex: 1, minHeight: 0 } : undefined}
>
<ScrollView
className="web:max-h-[80vh]"
contentContainerClassName="pb-4 md:pb-8"
contentContainerStyle={useFixedHeightLayout ? { flexGrow: 1 } : undefined}
style={useFixedHeightLayout ? { flex: 1 } : undefined}
showsVerticalScrollIndicator={false}
keyboardShouldPersistTaps="handled"
nestedScrollEnabled
onLayout={e => {
containerHeightRef.current = e.nativeEvent.layout.height;
setShowBottomFade(contentHeightRef.current > containerHeightRef.current + 4);
}}
onContentSizeChange={(_, h) => {
contentHeightRef.current = h;
if (containerHeightRef.current > 0) {
setShowBottomFade(h > containerHeightRef.current + 4);
}
}}
onScroll={e => {
const { contentOffset, contentSize, layoutMeasurement } = e.nativeEvent;
const atBottom =
contentOffset.y + layoutMeasurement.height >= contentSize.height - 8;
setShowBottomFade(!atBottom);
}}
scrollEventThrottle={16}
<KeyboardAvoidingView
behavior={Platform.OS === 'ios' ? 'padding' : 'height'}
enabled={Platform.OS !== 'web'}
style={useNativeFlexLayout ? { flex: 1, minHeight: 0 } : undefined}
>
<Animated.View
entering={contentEntering}
exiting={contentExiting}
key={contentKey}
<ScrollView
className="web:max-h-[80vh]"
contentContainerClassName="pb-4 md:pb-8"
contentContainerStyle={useFixedHeightLayout ? { flexGrow: 1 } : undefined}
style={useFixedHeightLayout ? { flex: 1 } : undefined}
showsVerticalScrollIndicator={false}
keyboardShouldPersistTaps="handled"
nestedScrollEnabled
onLayout={e => {
containerHeightRef.current = e.nativeEvent.layout.height;
setShowBottomFade(contentHeightRef.current > containerHeightRef.current + 4);
}}
onContentSizeChange={(_, h) => {
contentHeightRef.current = h;
if (containerHeightRef.current > 0) {
setShowBottomFade(h > containerHeightRef.current + 4);
}
}}
onScroll={e => {
const { contentOffset, contentSize, layoutMeasurement } = e.nativeEvent;
const atBottom =
contentOffset.y + layoutMeasurement.height >= contentSize.height - 8;
setShowBottomFade(!atBottom);
}}
scrollEventThrottle={16}
>
{children}
</Animated.View>
</ScrollView>
<Animated.View
entering={contentEntering}
exiting={contentExiting}
key={contentKey}
>
{children}
</Animated.View>
</ScrollView>
</KeyboardAvoidingView>
{showBottomFade && (
<View
pointerEvents="none"
Expand Down
Loading