Skip to content

Remove DepositBonusBanner component from card details - #2129

Merged
MusabShakeel576 merged 1 commit into
qafrom
claude/cool-cray-bc8fco
Jun 9, 2026
Merged

Remove DepositBonusBanner component from card details#2129
MusabShakeel576 merged 1 commit into
qafrom
claude/cool-cray-bc8fco

Conversation

@MusabShakeel576

Copy link
Copy Markdown
Contributor

Summary

This PR removes the DepositBonusBanner component and all related deposit bonus functionality from the card details page, simplifying the UI layout and reducing unnecessary dependencies.

Key Changes

  • Removed DepositBonusBanner component: Deleted the entire 140+ line component that displayed deposit bonus offers with configurable percentages and caps
  • Simplified layout:
    • Desktop: Changed from a flex-row layout with BorrowPositionCard and DepositBonusBanner to a single BorrowPositionCard
    • Mobile: Removed the DepositBonusBanner from the card details section
  • Removed unused imports and dependencies:
    • Linking from react-native (was only used for "Learn more" link in banner)
    • CARD_DEPOSIT_MODAL constant
    • useCardDepositBonusConfig hook
    • CardDepositSource and useCardDepositStore store
    • EXPO_PUBLIC_ENVIRONMENT from config
  • Cleaned up styles: Removed gradientOverlay, percentageCircles, and percentageCirclesMobile stylesheet definitions that were only used by the banner

Implementation Details

  • The BorrowPositionCard now takes full width on both desktop and mobile layouts
  • No functional changes to other card details features
  • All banner-related state management and configuration logic has been removed

https://claude.ai/code/session_01V7s9vkb32mh8HHBravEB5G

Removes the "Get X% bonus for deposit" borrow-deposit banner from both
the desktop and mobile card details layouts, along with its now-unused
imports and styles. The desktop borrow position card now spans the full
row width.

https://claude.ai/code/session_01V7s9vkb32mh8HHBravEB5G
@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
solid-app Ignored Ignored Jun 9, 2026 9:21am
solid-app-staging Ignored Ignored Jun 9, 2026 9:21am

Request Review

@MusabShakeel576
MusabShakeel576 merged commit 579f997 into qa Jun 9, 2026
4 of 5 checks passed
@MusabShakeel576
MusabShakeel576 deleted the claude/cool-cray-bc8fco branch June 9, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants