Remove percentage change from chart tooltips - #2134
Merged
Merged
Conversation
The savings rate chart (savings page) and token price chart (coins/[id] page) tooltips showed a period-over-period percentage change next to the date. Remove that change indicator from both the web (recharts ChartTooltip) and native (AreaChart) tooltips so they only display the value and the date. The selectedPriceChange store update is kept so the coin detail header's price-change indicator continues to work. https://claude.ai/code/session_01KE3gjUzyjkEN8ntFCkDTNC
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks the chart tooltip change from qa (#2130) onto
master.What changed
Removes the period-over-period percentage change indicator from the chart tooltips on the savings rate chart (savings page) and the token price chart (
coins/[id]page). Tooltips now show only the value and the date.components/ChartTooltip.tsx(web tooltip): removed the change-% block plus the now-unusedisPriceChangeprop,cnimport, andselectedPriceChangeselector read.components/AreaChart.web.tsx: stopped passingisPriceChange.components/AreaChart.tsx(native tooltip): removed the change-% block and the deadpriceChangestate/computation.The
setSelectedPriceChangestore updates are preserved so the coins page header's price-change indicator (a separate element) continues to work.Cherry-picked cleanly from commit
66f433e(merged to qa via #2130).https://claude.ai/code/session_01KE3gjUzyjkEN8ntFCkDTNC
Generated by Claude Code