fix(home): solid setup CTA + stop polling card details every 5s - #2180
Merged
Conversation
Promotes the home fixes from qa (PR #2176) to master. On master the stat cards were already refactored (minHeight + shared stat-value style), so the card-height jump is handled there; this carries the two fixes master still needs: - FinishSetupModal: use the solid `brand` button instead of the 20%-opacity `bg-button-earning` fill, which renders as a muted, disabled-looking green on the dark modal background. Keeps master's text-fitting tweaks. - cardDetailsQueryOptions: drop the 5s `refetchInterval` and raise staleTime to 60s. Card details (cashback totals/percentage) change rarely and the live balance is polled separately, so the interval was needlessly making the cashback card fall back to its loading skeleton. Cherry-picked from a74c14d (qa). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011pAKfpRFjbH5TJSfNimjJy
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the home fixes from qa (#2176) to
master.These came from three reported issues on the native home screen:
On
master, the stat cards have already been refactored (the home redesign usesminHeight+ a sharedHOME_STAT_VALUE_TEXT_STYLEand ashowSkeleton = isLoading && !cardDetailsguard), so the card-height jump (#1) is already handled there. This promotion therefore carries only the two fixesmasterstill needs:cardDetailsQueryOptions.ts— issue #2Drop the 5s
refetchIntervaland raisestaleTimeto 60s. Card details (cashback totals / percentage / card metadata) change rarely, and the live card balance is polled separately (cardBalance, every 5s). The interval was needlessly making the cashback card fall back to its loading skeleton "every few seconds."FinishSetupModal.tsx— issue #3Use the standard solid
variant="brand"button instead of the 20%-opacitybg-button-earningfill, which renders as a muted, disabled-looking green on the dark modal background. Master's text-fitting tweaks (numberOfLines/adjustsFontSizeToFit/ padding) are preserved.Cherry-picked from
a74c14d3(qa); the two stat-card files resolved to master's version since the redesign already covers that fix.Test plan
🤖 Generated with Claude Code
Generated by Claude Code