file explorer context - #851
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a shared Lit context contract for a File Explorer feature and exposes it from the package entrypoint, alongside a small fix to Menu’s item discovery logic to properly ignore only the trigger slotted element.
Changes:
- Add
FileExplorerContext/FileExplorerEditinterfaces andfileExplorerContext(@lit/context) for File Explorer state and callbacks. - Export the new context module from
src/index.tsas part of the public API. - Fix
Menu.syncItems()filtering to exclude onlyslot="trigger"children (instead of excluding all slotted children).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/lib/file-explorer/context.ts |
Adds a new Lit context definition and related TS interfaces for file explorer state/actions. |
src/index.ts |
Re-exports the new file-explorer context from the package entrypoint. |
src/components/menu/Menu.ts |
Adjusts menu item filtering to keep slotted menu items while excluding the trigger element. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SharonStrats
force-pushed
the
file-explorer-header
branch
from
August 5, 2026 06:50
00611fb to
b9beb7e
Compare
SharonStrats
force-pushed
the
file-explorer-header
branch
from
August 5, 2026 07:07
8a19958 to
0fcf24f
Compare
…istry@3.1.2-2) (latest: rdflib@2.4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create the file explorer context in solid-ui so it can be used in both solid-panes and solid-ui