Type Indexes - keeping functionality Discussion and Notes

[SharonStrats]

Currently we have the functionality to add the data location of specific data sets to the public and private type index. In researching further I found that this happens at the pane level. Currently contacts-pane, issue-pane, chat-pane have the functionality.

In solid-ui (login.ts) there is the registrationControl, which each of these pane uses to render the checkboxes for adding their data to either the public and/or the private index.

They all provide the functionality a little differently.

Contacts-pane has a sharing button which calls the same UI.aclControl.ACLControlBox5() that the sharing pane uses and it attaches the registrationControl from solid-ui to this screen so that a user can select whether to add it to the type indexes. For contacts-pane, theClass = ns.vcard('AddressBook').

Chat-pane mounts the same registrationControl in the chat preferences/settings. For chat-pane, theClass = ns.meeting('LongChat'). In create.ts it also adds an entry to the private type index in getChat, when the chat isn't found and it automatically creates one. (Side note: this code in create.ts is never used and is duplicated in solid-logic chatLogic, which also does not seem to be used.)

Issue-pane has a settings area as well and mounts the registrationControl there. For issue-pane, theClass = wf:Tracker.

My question is where should this functionality exist now that the sharing pane will be in a dialog for each resource driven by the header button controls in solid-panes.

My initial thoughts of a couple of ways we could handle this:

1. We could just keep the registration control in the panes.
2. We could conditionally add 'Discover publicly' and 'Discover privately' to the menu items, it would also need to be dynamically set based on whether it was already in the indexes (e.g. something like Undiscover publicly)