Skip to content

Change Node.js version to 20 in CI workflow#142

Merged
bourgeoa merged 1 commit intomainfrom
bourgeoa-npm
Apr 13, 2026
Merged

Change Node.js version to 20 in CI workflow#142
bourgeoa merged 1 commit intomainfrom
bourgeoa-npm

Conversation

@bourgeoa
Copy link
Copy Markdown
Contributor

Updated Node.js version in CI workflow from 22 to 20.

Updated Node.js version in CI workflow from 22 to 20.
Copilot AI review requested due to automatic review settings April 13, 2026 09:20
@bourgeoa bourgeoa enabled auto-merge April 13, 2026 09:21
@bourgeoa bourgeoa merged commit 9b395e7 into main Apr 13, 2026
10 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions CI workflow to use Node.js 20 for the npm-publish-latest publishing job, while the rest of the workflow continues to use newer Node versions.

Changes:

  • Switch npm-publish-latest job’s actions/setup-node node-version from 22 to 20.
  • Retain npm upgrade step (npm install -g npm@latest) for OIDC publishing flow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 76 to 79
- uses: actions/setup-node@v6
with:
node-version: 22
node-version: 20 # for npm@latest
registry-url: 'https://registry.npmjs.org'
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description suggests the CI workflow’s Node.js version was changed from 22 to 20, but this change only affects the npm-publish-latest job. The main build job still tests Node 22/24 and npm-publish-dev still pins node_version: 22. Please either update the PR metadata to reflect the narrower scope or align the other jobs/versions as intended.

Copilot uses AI. Check for mistakes.
Comment on lines +78 to 81
node-version: 20 # for npm@latest
registry-url: 'https://registry.npmjs.org'
- name: Update npm to latest (required for OIDC)
run: npm install -g npm@latest
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With npm-publish-latest running on Node 20, CI no longer validates the publish pipeline against the same Node version it publishes with (the build/test matrix is 22/24, and the release artifact is currently produced only when matrix.node-version == 22). Consider adding Node 20 to the test matrix and/or producing the publish artifact from the Node version you intend to support for publishing to avoid version-specific build/publish failures.

Copilot uses AI. Check for mistakes.
@bourgeoa bourgeoa deleted the bourgeoa-npm branch April 13, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants