-
Notifications
You must be signed in to change notification settings - Fork 2
Change Node.js version to 20 in CI workflow #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,7 +75,7 @@ jobs: | |
| name: build | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: 22 | ||
| node-version: 20 # for npm@latest | ||
| registry-url: 'https://registry.npmjs.org' | ||
| - name: Update npm to latest (required for OIDC) | ||
| run: npm install -g npm@latest | ||
|
Comment on lines
+78
to
81
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title/description suggests the CI workflow’s Node.js version was changed from 22 to 20, but this change only affects the
npm-publish-latestjob. The mainbuildjob still tests Node 22/24 andnpm-publish-devstill pinsnode_version: 22. Please either update the PR metadata to reflect the narrower scope or align the other jobs/versions as intended.