[FIX] resolve runtime SIGSEGV caused by QuickJS and mujs symbol collision - #378
Merged
Conversation
Signed-off-by: Texas0295 <kimura@texas0295.top>
…build Signed-off-by: Texas0295 <kimura@texas0295.top>
Signed-off-by: Texas0295 <kimura@texas0295.top>
Signed-off-by: Texas0295 <kimura@texas0295.top>
LittleSheep2Code
requested changes
Jul 14, 2026
LittleSheep2Code
self-requested a review
July 14, 2026 14:54
LittleSheep2Code
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #376
The prebuilt
libquickjs_c_bridge_plugin.soprovided byflutter_jsexports public symbols forjs_malloc,js_realloc, andjs_free. When the application initializesmedia_kit(which loadslibmpvand subsequentlylibmujs), a severe symbol collision occurs. The dynamic linker mistakenly routes QuickJS memory allocations to mujs functions, leading to an immediate segmentation fault (SIGSEGV) during runtime.Solution
Introduced the
quickjs_c_bridgesource as a submodule underlinux/third_party/to build the plugin from source with proper symbol isolation.Updated the GitHub Actions workflow to check out submodules and compile the bridge using CMake, ensuring symbols are properly restricted via visibility presets.
The compiled binary automatically overrides the flawed prebuilt file in the release bundle before packaging.