[codex] Keep browser smoke screenshots out of tracked baselines - #47
Merged
Merged
Conversation
Browser smoke tests wrote timeline acceptance screenshots directly into the tracked screenshots directory, so ordinary validation could dirty the worktree and push contributors toward cleanup hooks. Route default browser captures to the ignored target/browser-smoke/screenshots artifact directory instead, and reserve tracked baseline refreshes for the explicit --update-screenshots runner flag and make screenshots-update target. Update the README and demo docs to document the split between non-mutating smoke validation and intentional baseline refreshes.
blackopsrepl
marked this pull request as ready for review
May 13, 2026 18:36
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target/browser-smoke/screenshots/instead of trackedscreenshots/make screenshots-updateand--update-screenshotsfor intentional baseline refreshesContext
Fixes #46. Related to #45.
This is the separate browser-test workflow fix discussed while reviewing @benabel's TypeScript PR, so #45 can drop the pre-push screenshot reset workaround and stay focused on type-checking.
Validation
make test-browsernode tests/demo-browser-check.js --bad-optionmake test-frontendmake lint-frontendmake -n screenshots-updatemake ci-localNote: I did not run full
make screenshots-updatebecause this environment currently regeneratesrail-timeline-narrow.pngdifferently, and that command would intentionally update a tracked baseline outside this fix.