[codex] Fix Clarke-Wright metric-class scaling regression - #66
Merged
Conversation
Add an optional route_metric_class_fn hook to list-variable metadata and macro generation so route owners that share identical depot and distance behavior can share Clarke-Wright savings rows. Use the hook inside ListClarkeWrightPhase to compute savings per metric class while keeping owner-specific route feasibility and final owner matching. When no hook is supplied, each owner remains its own metric class, preserving the existing construction semantics.
Add a CVRP route_metric_class helper that groups owners by their backing ProblemData pointer. This gives Clarke-Wright a conservative proof that vehicles share depot and distance behavior without weakening owner-specific route feasibility. Re-export the helper through both solverforge-cvrp and the solverforge facade, and cover shared-data and distinct-data behavior with focused unit tests.
Add targeted Clarke-Wright regressions for route metric classes. The first proves that savings generation scales with metric classes rather than owner count; the second proves that owners sharing a metric class still keep owner-specific route feasibility during assignment.
Update the public macro, solver, facade, and CVRP wireframes for route_metric_class_fn and route_metric_class so the documented surface matches the new checked-in API. Also update the Clarke-Wright publication fixture and macro UI expectation so public examples and compile-fail diagnostics include the new supported planning_list_variable argument.
Bump the workspace version, inter-crate publish dependencies, lockfile entries, README, AGENTS guidance, and crate wireframes from 0.14.0 to 0.14.1. This prepares the patch release metadata for the Clarke-Wright metric-class fix without creating a tag, pushing remotes, or hand-editing changelog content.
Apply the repository rustfmt ordering and line wrapping to the new route metric class imports and test module declarations so the validation gate passes without changing behavior.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58d1d0d3a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Clarke-Wright construction scaling regression introduced by owner-aware route hooks.
The solver now supports an optional
route_metric_class_fnhook for planning list variables. Clarke-Wright computes savings once per metric class instead of once per owner when owners share identical depot and route-distance behavior. Owner-specific feasibility is still evaluated during merge and final assignment, so heterogeneous fleets keep their correctness boundary.This also exposes
solverforge::cvrp::route_metric_class, which groups CVRP owners by their backingProblemDatapointer, and prepares the workspace patch surface for0.14.1without tagging.Root Cause
The 0.14.0 owner-aware Clarke-Wright path generated savings for every owner and every customer pair. For benchmark models that use one route entity per customer, the large CVRP smoke case expanded from roughly
n^2savings ton^2 * owners, causing the watchdog timeout before construction could return.Changes
route_metric_class_fnmetadata and macro support.route_metric_classhelper and facade export.0.14.1release metadata.Validation
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-featuresmake build-cvrp-solverforgemake build-employee-scheduling-solverforgeX-n1001-k43returned hard-feasible in1.088swithwatchdog_killed=false;X-n101-k25andX-n106-k14also returned hard-feasible without watchdog kills.