BUILD-11593 Render CPU request as the avg denominator (schema 3) - #304
Conversation
GitHub Actions
Inactive
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
c95f3df to
bc8e6af
Compare
Consume the new cgroup.cpu.request_cores field (schema_version 3) so the
report shows "/ N cores requested" on burstable ARC runners instead of the
node-wide nproc value. Denominator preference in _rci_cpu_cell: limit ->
request -> online_count ("available") -> bare cores.
Also sync the producer hook copy (ci-metrics/job-completed.sh) with the
source in github-runners-infra: emit request_cores, bump schema to 3, and
use the request as the no-limit denominator.
Tests: 4 new _rci_cpu_cell tier cases; fixtures bumped to schema 3. 40
examples, 100% coverage.
…erence spec for synced hook - Remove BUILD-11593 references from inline comments across the changed files. - Cross-reference the _rci_cpu_cell spec from the producer hook's CPU-avg block so the hand-synced duplicate rendering stays pinned and can't drift unnoticed.
bc8e6af to
db00909
Compare
|
Code Review ✅ Approved 1 resolved / 1 findingsUpdates CI metrics to use the CPU request as the denominator in schema 3 for accurate ARC runner reporting. Ensure the newly added request-denominator branch in job-completed.sh is included in the test suite. ✅ 1 resolved✅ Quality: New request-denominator branch in job-completed.sh is untested
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
2 participants
What
Consume the new
cgroup.cpu.request_coresfield (metrics schema_version 3) so the CI Metrics report shows/ N cores requestedon burstable ARC runners instead of the misleading node-widenprocvalue (e.g./ 32 coreson asonar-xs).Ticket: BUILD-11593 · Producer PR: SonarSource/github-runners-infra#423
Changes
report-ci-metrics/lib.sh(_rci_cpu_cell): denominator preference is now limit → request (requested) → online_count (available) → bare cores.ci-metrics/job-completed.sh: synced producer-hook copy — emitsrequest_cores, schema 2 → 3, request-based denominator. (Differs from the infra copy only in the pre-existing feature-gate section.)_rci_cpu_celltier cases (limit / request-is-the-fix / WarpBuild available / bare); fixtures bumped to schema 3.Testing
40 examples, 0 failures;
report-ci-metrics/lib.sh+ orchestrator at 100% coverage (dockerized kcov). shellcheck clean.The key regression test asserts the ARC case renders
0.07 / 1 cores requested (7%)— i.e. the request, not nproc.