ECHOES-1385 Implement new EmptyState component#737
Conversation
✅ Deploy Preview for echoes-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jeremy-davis-sonarsource
left a comment
There was a problem hiding this comment.
Looks good! Nice work.
Just a few comments, but I'm trusting you to address them. No need for a re-review
(NP = Nitpicks, feel free to ignore)
|
Code Review ✅ Approved 2 resolved / 2 findingsImplements the reusable EmptyState component with comprehensive tests and Storybook coverage, addressing the hardcoded heading level finding. ✅ 2 resolved✅ Edge Case: Heading level hardcoded to h2 may break heading order
✅ Quality: EmptyState uses ref-as-prop while rest of codebase uses forwardRef
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |




Summary
Validation