SONARJAVA-6384 Fix S2160 FP when parent uses EqualsBuilder.reflectionEquals - #5899
Merged
Conversation
…Equals Skip the missing-equals issue when a parent equals implementation relies on Apache Commons Lang reflectionEquals, which already compares subclass fields.
Contributor
Cover the null-declaration and already-found reflectionEquals paths, and bump autoscan expected FPs now that bytecode-less analysis cannot see EqualsBuilder.reflectionEquals.
|
romainbrenguier
approved these changes
Aug 7, 2026
Code Review ✅ ApprovedFixes a false positive in S2160 when a parent class implements equals using Apache Commons Lang reflectionEquals. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
equalsvia Apache Commons LangEqualsBuilder.reflectionEquals(lang and lang3), which already compares subclass fields by reflection.equalsbody is available in the same compilation unit and callsreflectionEquals, the rule no longer asks subclasses to overrideequals.Test plan
EqualsNotOverriddenInSubclassCheckTest(lang3 + lang compliant cases;append-only parent still Noncompliant)