SONARJAVA-6752 Implement verifyIssueOnProject in JavaCheckVerifier and modernize MissingPackageInfoCheckTest

[romainbrenguier]

Summary

This is to fix the Quality Gate.

• Implement the previously unimplemented verifyIssueOnProject() method in JavaCheckVerifier (the newVerifier() backend)
• Migrate MissingPackageInfoCheckTest from the deprecated newInternalVerifier() to newVerifier()
• Update JavaCheckVerifierTest to verify verifyIssueOnProject works instead of asserting it throws

Part of RC-16

Test plan

• All 6 MissingPackageInfoCheckTest tests pass
• All 33 JavaCheckVerifierTest tests pass
• All InternalCheckVerifierTest tests pass

🤖 Generated with Claude Code

[hashicorp-vault-sonar-prod]

SONARJAVA-6752

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
4 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
97.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[alex-meseldzija-sonarsource]

LGTM

[alex-meseldzija-sonarsource]

LGTM

[hashicorp-vault-sonar-prod]

The target branch was unlocked and auto-merge was canceled to prevent unexpected actions.

[gitar-bot]

Code Review ✅ Approved 1 resolved / 1 findings

Implements verifyIssueOnProject in JavaCheckVerifier and modernizes MissingPackageInfoCheckTest, addressing the duplicated scan logic finding. No issues found.

✅ 1 resolved

✅ Quality: scanFilesForProjectIssues duplicates createVerifier scanning logic

scanFilesForProjectIssues() (lines 142-168) is almost a line-for-line copy of the scanning half of createVerifier() (lines 99-140): same version resolution, visitor list, SonarComponents, builder, cache handling and scanForTesting call. The only difference is the omission of the CommentLinesVisitor and the issue-collection tail. Extracting the shared scan setup into a single helper that both callers use would prevent the two paths from drifting (e.g. a future cache/classpath fix applied to only one). Not a functional bug, but worth consolidating.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}