Skip to content

Fix compilation error due to symbol rename #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrea-guarino-sonarsource merged 1 commit into from
Sep 26, 2019
Merged

Fix compilation error due to symbol rename #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python-checks/src/main/java/org/sonar/python/checks/FieldDuplicatesClassNameCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import org.sonar.python.PythonSubscriptionCheck;
import org.sonar.python.api.tree.PyClassDefTree;
import org.sonar.python.api.tree.Tree;
import org.sonar.python.semantic.TreeSymbol;
import org.sonar.python.semantic.Symbol;

@Rule(key = "S1700")
public class FieldDuplicatesClassNameCheck extends PythonSubscriptionCheck {
Expand All @@ -40,7 +40,7 @@ public void initialize(Context context) {
return;
}
String className = classDef.name().name();
Set<TreeSymbol> allFields = new HashSet<>(classDef.classFields());
Set<Symbol> allFields = new HashSet<>(classDef.classFields());
allFields.addAll(classDef.instanceFields());
allFields.stream()
.filter(symbol -> className.equalsIgnoreCase(symbol.name()))
Expand Down