Skip to content

ComfyUI Base 3.20.3

Choose a tag to compare

@github-actions github-actions released this 17 Oct 16:58
· 4 commits to main since this release
dadf9cf

ComfyUI Base 3.20.3: the CPU-quota and launch-env tests hold on any machine (#39)

Workspace integration run 39049424709 (job workspace, on the free
soulcraft-hf runner, base-v3.20.1) still failed three base unit tests.
The code was right; the tests read the runner's own environment:

Test What the runner did
test_unit_the_cpu_quota_is_the_cgroups_not_the_hosts 2 CPUs
online, so the cap turned the fake 250000 100000 quota into 2, not 3
test_unit_launch_env_precedence_machine_then_packages_then_the_quota
exports OMP_NUM_THREADS=2, which (per the contract) wins over every
package and quota value
test_unit_launch_env_reaches_comfyui_and_only_comfyui same
OMP_NUM_THREADS=2

Change (suite only; no base code changed)

  • Quota test:
  • The rounding cases run with _base_cpus_online stubbed to 64, so they
    prove the rounding on any host. With 2 CPUs, rounding up and rounding
    down both give 2, so the old cases proved nothing there.
  • The cap is proved twice: with the host's own count (the existing case,
    unchanged), and with a stubbed 2-CPU host (250000 100000 gives 2).
  • Launch-env tests:
  • A _no_launch_env(monkeypatch) helper deletes every key of the base's
    own BASE_LAUNCH_ENV_KEYS (read from base.sh, so it stays in step
    with the contract) plus any CT2_* from the suite's environment.
  • Both tests stub 64 CPUs, so the fake quotas (3 and 2) are never
    capped.
  • Every assertion is unchanged, including the one that the machine's own
    OMP_NUM_THREADS=5 wins.
  • VERSION 3.20.3 (on top of 3.20.2), handbook line 3 and a §10 entry.
    package.py --base rebuilt the zip (the suite ships), and --base --check says it is current.

Tested

Nothing ran on the Mac. py_compile passes, and I checked by hand that
the edited bash snippets build the intended strings. This PR's CI covers
ubuntu. The soulcraft-hf integration run after the pin move covers the
runner.

🤖 Generated with Claude Code

Co-authored-by: Claude Opus 5.5 noreply@anthropic.com

The zip is what a pod installs. Handbook: comfyui-base-handbook.md