fix: v0.51.0 lcov branch-coverage rc key for lcov 1.15 (Ubuntu 22.04) - #63
Merged
Merged
Conversation
Checking the actual v0.50.0 release run's logs found "branches...: no data found" -- the --rc branch_coverage=1 flag added in that milestone had no effect in real CI. Ubuntu 22.04's apt-get install lcov provides lcov 1.15, which predates the branch_coverage rc-key rename; confirmed directly from lcov v1.15's own lcovrc.5 man-page source (lcov_branch_coverage, not branch_coverage). Passes both --rc lcov_branch_coverage=1 (the name lcov 1.15 actually recognizes) and --rc branch_coverage=1 (forward-compatible with lcov 2.x) to every lcov invocation in both ci.yml and release.yml. Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checking the actual v0.50.0 release run's logs found
branches...: no data found— the--rc branch_coverage=1flag added in that milestone had no effect in real CI.Root cause: Ubuntu 22.04's
apt-get install lcovprovides lcov 1.15, which predates thebranch_coveragerc-key rename. Confirmed directly from lcov v1.15's ownlcovrc.5man-page source on GitHub: the recognized key islcov_branch_coverage, notbranch_coverage.Fixed by passing both
--rc lcov_branch_coverage=1(what lcov 1.15 actually recognizes) and--rc branch_coverage=1(forward-compatible with lcov 2.x) to everylcov --capture/--removecall in bothci.ymlandrelease.yml.Test plan
cmake --build buildclean (no source changes, sanity rebuild)ctest— 41/41 passingcfusa check/lint/analyze/cyber/trace/qualify— all exit 0