fix: pin cpp-FuSa checkout to v0.15.0 in CI workflows - #16
Merged
Conversation
Both the fusa-asil-b and sarif jobs in ci.yml checked out cpp-FuSa from its default branch, floating on whatever main happened to be at CI run time. Pin both to the released ref: v0.15.0 tag. Closes #15 Signed-off-by: Matt <47545907+SoundMatt@users.noreply.github.com>
This was referenced Jul 28, 2026
SoundMatt
added a commit
that referenced
this pull request
Jul 30, 2026
CI's `go install github.com/SoundMatt/RELAY/cmd/relay@latest` used the bare (pre-v2) module path. Since RELAY v2.0.0, Go's semantic import versioning rules require the /v2 suffix for that path to resolve at all — the bare path has been silently resolving to the last v1.x tag (v1.14.0) this whole time, three spec releases behind (v1.12, v1.13, v1.14, v2.0 all shipped since), and would keep resolving there forever now that v2.x tags live under the new path (RELAY#70). Changed to `go install github.com/SoundMatt/RELAY/v2/cmd/relay@v2.0.4`, an explicit pin rather than @latest, matching this repo's existing "pin, don't float" convention for external tool checkouts (e.g. cpp-FuSa is pinned to v0.15.0 in the same workflow, #16). Verified conformance against the real RELAY v2.0.4 CLI (built the same way CI now will) before pushing: - `relay conform --strict ./build/cli/cpp-lin-cli` — PASS - `relay interop --strict --protocol LIN ./build/cli/cpp-lin-cli` — PASS, including both LIN error vectors (lin-id-overflow, lin-diagnostic-wrong-checksum). Those reject-path vectors were never actually exercised by any implementation's CI before now — RELAY v1.13 fixed a `go:embed` glob bug that had made spec/vectors/errors/* unreachable via the Vector API, so `relay interop`'s error-path comparison silently only ever ran the happy path. cpp-LIN's validate_frame() already rejects both cases correctly, so no gap. Read RELAY spec/CHANGELOG.md v1.12/v1.13/v1.14/v2.0 in full: v1.12 (add "c" as a valid CLI language) and v1.14 (RCP/DDS module-name registry) don't touch LIN or C++. v1.13's §18.2 HealthProvider/MetricsProvider/ Drainer C++ binding shapes are optional-interface documentation, not a new mandatory requirement — no code change needed. v2.0's RCP canonical-type replacement is RCP-specific, as expected, and doesn't touch LIN. No library code or test vectors changed, and no new conformance gap was found, so no version bump — consistent with this repo's precedent for pure CI-pin fixes (#16, which also didn't bump the version). Full local suite also re-run and green: 171/171 ctest, ASan+UBSan (171/171). clang-tidy/gcc-12 aren't available on this machine and weren't run locally; CI runs them natively on Ubuntu with the pinned versions this workflow already specifies. Signed-off-by: Matt <47545907+SoundMatt@users.noreply.github.com>
6 tasks
SoundMatt
added a commit
that referenced
this pull request
Jul 30, 2026
Both the fusa-asil-b and sarif jobs in .github/workflows/ci.yml were pinned to cpp-FuSa v0.15.0 (#16), three releases behind the current v0.18.0. Bump both checkouts. Built cpp-FuSa v0.18.0 locally the same way CI does and ran the full fusa-asil-b gating sequence (init, check, lint, trace, cyber, qualify, hara init, iso26262, iec61508, boundary, tara, fmea, safety-case, sas, sci, badge, vuln, metrics, report) plus the sarif job's check --format sarif against cpp-LIN's own tree, for real, before pushing. No new ERROR-level findings: check/lint/cyber/qualify all pass clean (0 errors), identical to v0.15.0's clean-pass status; qualify's 8/8 case suite still passes. cyber's scanned-file count dropped from 28 to 16 (findings 43 -> 33) between the two binaries — traced to upstream commit 8564bf0 (part of the v0.16-v0.18 range), which fixed source-walking commands to honour .fusa.json's sourceDirs (["src", "include"]) per x-FuSa spec S1.2.1. v0.15.0 was over-scanning cli/ and tests/, outside this project's declared source scope; v0.18.0 correctly excludes them. This is a upstream bug fix, not a suppression of real findings. iso26262/iec61508 gap-report commands still exit 1 (gaps > 0, expected for a project without full formal ISO 26262 documentation) but both calls in ci.yml are already wrapped in `|| true`, unchanged from v0.15.0's behavior. Full local suite re-run clean: cmake/ninja Release build (171/171 ctest), ASan+UBSan Debug build (171/171 ctest). ThreadSanitizer could not be exercised locally (this sandbox's arm64 toolchain lacks a linkable libtsan runtime); CI runs it natively on ubuntu-22.04/gcc-12 where TSan is supported, unaffected by this change. No version bump: pure CI-tool-pin fix with no behavior change and no new findings, same category as #16 and #50 (neither bumped the version or touched CHANGELOG.md). Signed-off-by: Matt <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fusa-asil-bandsarifjobs in.github/workflows/ci.ymlchecked outSoundMatt/cpp-FuSafrom its default branch (unpinned/floating). Pin both checkouts to the releasedref: v0.15.0tag so CI evidence is reproducible and not silently affected by upstream tool changes..github/workflows/*.ymlfor every occurrence of the cpp-FuSa checkout pattern — confirmed exactly two (fusa-asil-b job, sarif job), both fixed.dco.ymlandrelease.ymldo not reference cpp-FuSa.Closes #15
Test plan
fusa-asil-bjob (cpp-FuSa safety-lifecycle qualification), since pinning to a released version could surface differences vs. whatever main currently produces.