Feat: Add warning messages for classic spawns - #166
Closed
notkoen wants to merge 3 commits into
Closed
Conversation
QoL change for CS2 ZE to give new players a heads up warning if zombies will be spawning between humans, aka "classic spawns."
notkoen
marked this pull request as ready for review
January 24, 2024 18:58
Vauff
requested changes
Jan 27, 2024
Vauff
left a comment
Vauff
left a comment
Contributor
There was a problem hiding this comment.
This behaviour should be an opt-in convar, because a warning like this is redundant on servers like Mapeadores that have classic spawn part of their primary settings.
Comment on lines
-860
to
+865
| V_snprintf(message, sizeof(message), "First infection in \7%i %s\1!", g_iInfectionCountDown, g_iInfectionCountDown == 1 ? "second" : "seconds"); | ||
| if (g_iInfectSpawnType != EZRSpawnType::RESPAWN) | ||
| V_snprintf(message, sizeof(message), "Classic spawns enabled! Zombies will be spawning between humans!\nFirst infection in \7%i %s\1!", g_iInfectionCountDown, g_iInfectionCountDown == 1 ? "second" : "seconds"); | ||
| else | ||
| V_snprintf(message, sizeof(message), "First infection in \7%i %s\1!", g_iInfectionCountDown, g_iInfectionCountDown == 1 ? "second" : "seconds"); |
Contributor
There was a problem hiding this comment.
You need to split this up, because this same buffer is being used for both hud msgs and chat msgs. As a result it spams the chat a lot more than once too.
Was this even tested? Because the chat formatting is also garbled due to newline in chat messages being interpreted as gray colour.
Contributor
Author
There was a problem hiding this comment.
I couldn't test it because I don't even have a test server. I'll fix it later.
notkoen
marked this pull request as draft
January 27, 2024 14:48
Contributor
Author
|
Too lazy lmao |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QoL change to give new players a heads-up warning if zombies will be spawning between humans, aka "classic spawns."
Feedback is appreciated and welcome as to how this should be properly implemented. Some ideas are taken from CSS.