feat: Use clock for getting default log event time#112
Merged
Bungeefan merged 10 commits intoSourceHorizon:mainfrom Mar 15, 2026
Merged
Conversation
Member
|
@alverone Thanks for the PR, it is now merged! FYI: I changed some things (as you can see above), especially dropping the tests that only tested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
clockand a dev dependency onfake_asyncwhere the lowest package version are compatible with the current Dart SDK constraint,DateTime.now()withclock.now()so that log events produced within a zone with a customClockreport the time from that zone,fake_asyncand regular zones.See the related issue/feature request: #111
Other notes
Here is the output of the added test case for
Clocks within different zones: