windows: honor MOZBUILD_STATE_PATH + host fd hard-cap in cross script#81
Merged
Conversation
First CI run failed: the workflow bootstraps into $GITHUB_WORKSPACE/.mozbuild (MOZBUILD_STATE_PATH) but the script hardcoded ~/.mozbuild for clang/cbindgen, so 'cbindgen not found'. Also GitHub runners cap the fd hard limit at 65536 so 'ulimit -n 1048576' failed and the ciopfs daemon stayed at 1024 — now raise to the host's hard cap wherever we run (65536 is ample at CI parallelism).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the first CI run of the Windows lane (run 30006453773):
cbindgen not found— workflow bootstraps into$GITHUB_WORKSPACE/.mozbuild(MOZBUILD_STATE_PATH) but the script hardcoded~/.mozbuildfor clang + cbindgen defaults. Now derives both fromMOZBUILD_STATE_PATH.ulimit -n 1048576failed. Now raises to the host's hard cap (ulimit -Hn) everywhere; 65536 is ample at CI parallelism.The merge push retriggers the lane via its own path filter.