Skip to content

workstation-v0 keyboard remap policy validation#116

Merged
mdheller merged 6 commits into
mainfrom
review/workstation-keyboard-v1
Apr 25, 2026
Merged

workstation-v0 keyboard remap policy validation#116
mdheller merged 6 commits into
mainfrom
review/workstation-keyboard-v1

Conversation

@mdheller

@mdheller mdheller commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

Adds a focused keyboard/remap policy validation tranche for the Mac-on-Linux workstation lane.

Actor:

  • opened a clean branch from current main
  • added check-keyboard-policy.sh
  • added keyboard policy CI smoke workflow
  • documented the current policy in the GNOME workstation README

Generator:

  • encodes the current policy as machine-readable key=value output
  • keeps input-remapper as the primary Fedora/GNOME backend
  • keeps xremap as an advanced compatibility lane
  • keeps Kinto as explicit X11/xkeysnail compatibility, not auto-installed in the Wayland-first profile

Critic findings and remediation:

  • Finding: the first helper only exposed selected backend validity, not the canonical policy. Remediated by adding default_backend, primary_backend, compatibility_backends, wayland_first, and kinto_auto_install outputs.
  • Finding: the first helper did not report whether the selected backend binary is available. Remediated by adding selected_backend_available output.
  • Finding: CI did not assert template contents strongly enough. Remediated by checking left and right modifier mappings in the generated xremap template.
  • Finding: policy_ok can be confused with runtime readiness. Partially remediated by documenting the distinction; follow-up should add an explicit runtime_ready output once the connector accepts the helper rewrite.

This keeps policy validation separate from future remap daemon changes.

@mdheller mdheller merged commit 6623ab5 into main Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant